Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve messaging for removed flags #108

Merged
merged 5 commits into from
Mar 25, 2024
Merged

improve messaging for removed flags #108

merged 5 commits into from
Mar 25, 2024

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Mar 20, 2024

Make it clearer if a removed flag still has instances in the codebase

CleanShot 2024-03-20 at 11 45 00

Copy link

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Show: Live Tiles show-widgets show-widgets ⚠️ not all references removed

@jazanne jazanne changed the title Jwhite/removed improve messaging for removed flags Mar 20, 2024
@github-actions github-actions bot added the ld-flags LaunchDarkly flags have been detected in the PR diff label Mar 20, 2024
@jazanne jazanne marked this pull request as ready for review March 20, 2024 15:46
@jazanne jazanne requested a review from a team March 20, 2024 15:46
@jazanne jazanne merged commit 211247e into main Mar 25, 2024
5 checks passed
@jazanne jazanne deleted the jwhite/removed branch March 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ld-flags LaunchDarkly flags have been detected in the PR diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant