Skip to content

Commit

Permalink
enable github integration (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
jazanne authored Mar 1, 2024
1 parent 190a865 commit e218a18
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
17 changes: 8 additions & 9 deletions internal/ldclient/flag_links.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,20 +125,19 @@ func makeFlagLinkRep(event *github.PullRequestEvent, flagKey, message string) *l
timestamp = &m
}

// TODO enable integration once capability is available
// integration := "github"
integration := "github"
id := strconv.FormatInt(*pr.ID, 10)
// key must be unique
key := fmt.Sprintf("github-pr-%s-%s", id, flagKey)

return &ldapi.FlagLinkPost{
DeepLink: pr.HTMLURL,
Key: &key,
// IntegrationKey: &integration,
Timestamp: timestamp,
Title: getLinkTitle(event),
Description: pr.Body,
Metadata: &metadata,
DeepLink: pr.HTMLURL,
Key: &key,
IntegrationKey: &integration,
Timestamp: timestamp,
Title: getLinkTitle(event),
Description: pr.Body,
Metadata: &metadata,
}
}

Expand Down
1 change: 1 addition & 0 deletions testdata/test
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ show-widgets
oldPricingBanner
show_widgets
oldPricingBanner
mobile-app-promo-ios

0 comments on commit e218a18

Please sign in to comment.