Dacumentation-page #1

latifa-wakili · 2024-05-25T20:01:33Z

new repo about a Dacumentation-page
iclude this files:
index.html
styles.css
README.md

ahzamir

Hi @latifa-wakili 🙋‍♀️,

Excellent work! You have done a great job implementing the project requirements but your project still misses some of the requirements:

Well done, your code passes all the tests on freecodecamp.
Your HTML code is not clean for more details check the inline comments below.
You have to update your README.md file and add your own project details.

Status: Required Changes 🔁

Make changes to your code and commit and request for a re-review.

Highlights 🌞

🎯 Great Design implemented.

✔️ Created a professional Repo (You created a repository with your project name)
✔️ Correct use of Gitflow (You created the development branch and made it your default branch, then created and committed your work on your feature branch)
✔️ Commit messages are meaningful
✔️ Setup the linters correctly (You added the correct linters config into your project according to the language you used on your code)
✔️ No linter errors (All linters checks have been passed 🟢)
✔️ You have followed and completed the Technical Documentation Page and all requirements.
✔️ Created the pull request (From your feature branch to the development branch you created a pull request and submitted the pull request link for review)
✔️ Good PR description (You added a meaningful description to your PR about your work and the features you added on this pull request)
✔️Your Project has a README.md file
❌Your README.md contains your project details
❌Your code is clean

Cheers 🥂 and Happy coding!!! 👯 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @ahzamir in your question so I can receive the notification.

ahzamir · 2024-05-27T08:23:22Z

index.html

Your HTML code is not clean and properly aligned. Please use 2 spaces for indentation. Additionally, ensure that child elements are properly indented under their parent elements. Here's an example to help you:

Incorrect:

<!DOCTYPE html> <html> <head> <title>Page Title</title> </head> <body> <h1>This is a Heading</h1> <p>This is a paragraph.</p> </body> </html>

Correct:

<!DOCTYPE html> <html> <head> <title>Page Title</title> </head> <body> <h1>This is a Heading</h1> <p>This is a paragraph.</p> </body> </html>

Rule: Each child element should be indented 2 spaces under its parent element for better readability and maintainability.
Hint: Go to the VSCode bottom right corner, you can see "Spaces: 4" (or a similar indicator). Click on that, then click on "Indent Using Spaces" and select 2. You can also use the gray color column lines to help you know where your parent and child elements should be.

ahzamir · 2024-05-27T08:24:09Z

README.md

Add your project details in all sections, and remove those parts that you don't know or your project does not have it.

latifa-wakili · 2024-05-27T09:43:02Z

@ahzamir sir I update my project after your feedback but i couldnt add demo on readme file

ahzamir

@latifa-wakili

Still your code has some issues try to get help from your partner to solve the issues.

ahzamir · 2024-05-27T15:18:37Z

README.md

+## Demo 📸
+
+
+![Demo](c:\Users\DELL\OneDrive\Pictures\Screenshots\Screenshot (8).png)


You have used an external folder link for your screenshot which is wrong. First You have to add your image to your project folder then use the internal image link from inside of your project.

ahzamir · 2024-05-27T15:20:48Z

index.html

Still, your code has lots of spacing issues, ask your partner to help you with that and learn how to solve it.

Your HTML code is not clean and properly aligned. Please use 2 spaces for indentation instead of 1-3-4 or no spaces. Additionally, ensure that child elements are properly indented under their parent elements. Here's an example to help you:

Incorrect:

<!DOCTYPE html> <html> <head> <title>Page Title</title> </head> <body> <h1>This is a Heading</h1> <p>This is a paragraph.</p> </body> </html>

Correct:

<!DOCTYPE html> <html> <head> <title>Page Title</title> </head> <body> <h1>This is a Heading</h1> <p>This is a paragraph.</p> </body> </html>

Rule: Each child element should be indented 2 spaces under its parent element for better readability and maintainability.
Hint: Go to the VSCode bottom right corner, you can see "Spaces: 4" (or a similar indicator). Click on that, then click on "Indent Using Spaces" and select 2. You can also use the gray color column lines to help you know where your parent and child elements should be.

latifa-wakili · 2024-05-29T06:16:55Z

@ahzamir I cleaned my html codes by helping my partner (Zainab behzad) and add a photo of my project on demo part of README.MD file.

for doing it late i am sorry i was on the way of ghor to kabul

ahzamir · 2024-06-01T07:54:46Z

README.md

+
+```html
+<!--  </header>
+    <li class="li">Writing into an alert box, using window.alert().</li>
+    <li class="li">Writing into the browser console, using console.log().</li> -->
+```
+
+```css
+/* 
+.li {
+  font-family: Arial, Helvetica, sans-serif;
+}
+ */
+```
+
+```javascript
+//  class Car {
+        constructor(name, year) {
+          this.name = name;
+          this.year = year;
+        }You can also include JavaScript code snippets.
+```


Remove these part

ahzamir · 2024-06-01T07:55:26Z

README.md

+Provide step-by-step instructions on how to install and set up your project. Include any dependencies or prerequisites that need to be installed.
+
+```bash
+# git.


Add this code here (# git clone [email protected]:latifa-wakili/Documentation-page.git)

ahzamir · 2024-06-01T07:56:21Z

README.md

+```
+
+```bash
+# github.


And add this one here (# cd Documentation-page)

ahzamir · 2024-06-01T07:56:46Z

README.md

+[email protected]:latifa-wakili/Documentation-page.git cd Documentation-page
+```bash
+# vscode.
+```


Remove this after you moved it up

@ahzamir sir I did steps you said about my readme file please re review it now

ahzamir

Hi @latifa-wakili 🙋‍♀️,

Excellent work! 💯 You have done a great job implementing all the project requirements. 🥳 Your feature is complete! Congratulations!!!🎊

[REQUIRED] Share your project on this GROUP, add a simple Proud Moment text and a screenshot of your project then besides that add your project link at the end of the text as a GitHub Source code reference and post.
Share your Project on your LinkedIn account and add a proud moment text on it with a screenshot.
Well Done great design Implemented. 🎯🎉👍

Status: Approved ✅

There is nothing to say other than to merge your branch. 🎉🎯✅👍😊🥳

Highlights 🌞

🎉 Great Design Implemented
✔️ Created a professional Repo (You created a repository with your project name)
✔️ Correct use of Gitflow (You created the development branch and made it your default branch, then created and committed your work on your feature branch)
✔️ Commit messages are meaningful
✔️ Setup the linters correctly (You added the correct linters config into your project according to the language you used on your code)
✔️ No linter errors (All linters checks have been passed 🟢)
✔️ You have followed the Documentation Page project task and committed using the command line
✔️ Created the pull request (From your feature branch to the development branch you created a pull request and submitted the pull request link for review)
✔️ Good PR description (You added a meaningful description to your PR about your work and the features you added on this pull request)
✔️Your code is clean
✔️Your repo has a professional README.md

Cheers 🥂 and Happy coding!!! 👯 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @ahzamir in your question so I can receive the notification.

latifa added 7 commits May 26, 2024 00:27

added new files

d4ae591

add html and css codes

654dbdf

add README.MD file

7b4b56e

cleaning codes

2e68450

indentnation

5e750d9

clean extra spaces

2c9ab03

cleaning spaces

fe14d5a

ahzamir suggested changes May 27, 2024

View reviewed changes

latifa added 2 commits May 27, 2024 07:05

edeit codes

a7e7ba3

update elements

1036304

ahzamir suggested changes May 27, 2024

View reviewed changes

latifa added 9 commits May 27, 2024 11:58

update new codes

48f8dc6

cleaning code

55db9d0

cleaning styles codes

d500a5e

update indentenation

fe99470

clean indent

c7b15b6

check agin

0728097

give some new styles

b3b07dc

update project

93b493c

update readme file

00f8ee8

latifa added 4 commits May 29, 2024 10:28

update files

50100ed

cleaning html codes

1288ba6

re review my readme file

cd93fb8

cleaning codes

7893101

ahzamir reviewed Jun 1, 2024

View reviewed changes

latifa added 2 commits June 1, 2024 15:55

update information on readme.md file

5005cf1

update readme file

38f6fb8

ahzamir approved these changes Jun 2, 2024

View reviewed changes

latifa-wakili merged commit fdb616a into main Jun 2, 2024
4 checks passed

latifa-wakili had a problem deploying to github-pages June 5, 2024 13:56 — with GitHub Pages Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dacumentation-page #1

Dacumentation-page #1

latifa-wakili commented May 25, 2024

ahzamir left a comment

ahzamir May 27, 2024

ahzamir May 27, 2024

latifa-wakili commented May 27, 2024

ahzamir left a comment

ahzamir May 27, 2024

ahzamir May 27, 2024

latifa-wakili commented May 29, 2024

ahzamir Jun 1, 2024

ahzamir Jun 1, 2024

ahzamir Jun 1, 2024

ahzamir Jun 1, 2024

latifa-wakili Jun 1, 2024

ahzamir left a comment

		## Demo 📸


		![Demo](c:\Users\DELL\OneDrive\Pictures\Screenshots\Screenshot (8).png)

Dacumentation-page #1

Dacumentation-page #1

Conversation

latifa-wakili commented May 25, 2024

ahzamir left a comment

Choose a reason for hiding this comment

Hi @latifa-wakili 🙋‍♀️,

Status: Required Changes 🔁

Highlights 🌞

Choose a reason for hiding this comment

Choose a reason for hiding this comment

latifa-wakili commented May 27, 2024

ahzamir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

latifa-wakili commented May 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahzamir left a comment

Choose a reason for hiding this comment

Hi @latifa-wakili 🙋‍♀️,

Status: Approved ✅

Highlights 🌞