-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging issues 777 and 778 #1607
base: develop
Are you sure you want to change the base?
Conversation
@FrankMittelbach @davidcarlisle I have now changed the taggging of presentation tables to use "normal" tags and an ARIA attribute. This works better with derivation. OK? |
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see question about plug settings
\AddToHook{cmd/frontmatter/before}{\par\@@_sec_end:n{-10}} | ||
\AddToHook{cmd/mainmatter/before} {\par\@@_sec_end:n{-10}} | ||
\AddToHook{cmd/backmatter/before} {\par\@@_sec_end:n{-10}} | ||
\AddToHook{cmd/appendix/before} {\par\@@_sec_end:n{-10}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better would be to move the \par command into those comands eventually (to ensure that they always behave identically (with or without tagging).
Also (not checked) but isn't \@@_sec_end:n{-10}
a related command and should be in a socket rather than a hook?
Doesn't have to be done now, but there should be a TODO if this is something we should cleanup at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if a \par inside \@@_sec_end:n
is always wanted that's why I added if here explicitly (In the other cases the command is currently is used inside the sectioning commands in vmode, so a \par inside the command is not needed).
I'm not sure what you mean by sockets. \mainmatter etc are defined by the classes, so we can not simply redefine them to add a socket but have to use a generic hook. The problem was that the hook is before the \clearpage and so not necessarly in vmode.
\__tag_tbl_enable: | ||
\AssignSocketPlug{tagsupport/tbl/hmode/begin}{LayoutTable} | ||
\AssignSocketPlug{tagsupport/tbl/vmode/begin}{LayoutTable} | ||
\clist_clear:N \l_@@_header_rows_clist | ||
\clist_clear:N \l_@@_header_columns_clist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I go from presentation back to table/tagging=on it should probably reset the plugs or not? If so the plugs have to be set also above, as this this might happen on the same group level.
If my assumption is correct, then this also needs a test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\__tag_tbl_enable:
sets all sockets, including the begin sockets to the defaults. So the presentation mode only has to overwrite the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and there is a testfile (table-015-presentation in testfiles-table-luatex) which tests the switch from presentation back to normal tagging in one group.
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
(and/orlatexchanges.tex
) updated