-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure APT after manual installation of google-chrome-stable #1959
Reconfigure APT after manual installation of google-chrome-stable #1959
Conversation
Is there anything unique in your Homestead setup, because the web driver installation succeeds fine for me. I don't fully understand what this change is doing. Can you explain a little more what the additional line is supposed to do? |
While our setup is customized, I can replicate it with a basic example. Below are the steps I used. In an empty folder:
On a clean copy of Homestead main (e.g.
The error occurs during this step: homestead/scripts/features/webdriver.sh Lines 25 to 29 in 5125ef3
Click here to see the relevant part of the output.
@browner12, are you using an ARM Mac? If so that would explain why you can't reproduce the issue, since the problem command is skipped on AArch64. |
Thanks for the explanation. Yes, I am on an ARM Mac. |
@browner12 You can reproduce the issue on an ARM Mac using Docker: docker run -it --rm --platform linux/amd64 ubuntu:jammy Running the following in Docker will cause the error described above: apt-get update \
&& apt-get install -y wget \
&& wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -O /tmp/chrome.deb \
&& dpkg -i /tmp/chrome.deb I don't use Homestead anymore and stumbled across this PR by chance, but I would suggest the following change to fix it: -dpkg -i /tmp/chrome.deb
+apt-get install -y /tmp/chrome.deb The following will work inside the amd64 docker image: apt-get update \
&& apt-get install -y wget \
&& wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -O /tmp/chrome.deb \
&& apt-get install -y /tmp/chrome.deb |
@vintagesucks I think I went with doing it this way assuming there was a reason |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
After the recent changes in #1932, the Chrome Web Driver installation script fails. This PR fixes this by ensuring that
apt-get
is called with--fix-broken install
afterwards, to ensure that the dependencies are resolved and google-chrome-stable is actually configured.