Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fixes memory leak on PHPUnit's Annotations registry #44324

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

nunomaduro
Copy link
Member

This pull request addresses one of the memory leaks being mentioned at #44214, by performing a proper cleaning of the PHPUnit's Annotations registry.

On Vapor's test suite, here is the results on 600 tests: 26% less memory used.

// Before
Time: 00:57.879, Memory: 156.50 MB

// After
Time: 00:57.803, Memory: 116.50 MB

The "Before" results, already contains the fixes #44307, #44306, https://github.com/bugsnag/bugsnag-laravel, bugsnag/bugsnag-php#651.

@taylorotwell taylorotwell merged commit 211be64 into 9.x Sep 27, 2022
@taylorotwell taylorotwell deleted the fix/memory-leaks-in-test-suite-docs branch September 27, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants