Password reset - allow success response on invalid user #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e email not found, setting this to true will return a success response preventing an intruder from fishing for valid email addresses.
|
Even after this PR they could just attempt to register and see if the email is already taken? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small security feature:
Adding a config flag to allow for responses to appear as successful when invalid emails are submitted during password resets, preventing intruders from fishing for valid email addresses
When used in combination with laravel, I would suggest just updating the reset success message to be more verbose in
resources/lang/en/passwords.php:sentSomething like this:
An email has been sent to the address provided, if it exists in our system. Please check your inbox for further instructions on how to reset your account. If you don't receive an email within a few minutes, please ensure that the email address entered is correct and try again. For security reasons, we do not confirm the existence of email addresses in our system.