Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add development support #11

Open
RavenOfTime opened this issue Oct 12, 2024 · 5 comments
Open

Request: Add development support #11

RavenOfTime opened this issue Oct 12, 2024 · 5 comments

Comments

@RavenOfTime
Copy link

Hey,

I want to contribute to this project, please add some instructions or point me in the right direction.

Many thanks for considering my request.

@lyang2821
Copy link
Collaborator

Hi, thanks for your interest.

I'd suggest to start with the high level architecture of the different components.
https://docs.lap.dev/self-host-administration/architecture

Also, is there any specific feature or bug you'd like to work on and I can give you more details on it.

@RavenOfTime
Copy link
Author

Hey Lyang,

Thanks for your reply,
I have started to work on the Gitlab Self Hosted bits

I was able to run and edit the Lapdev-Dashboard & Api, but I am unable to run the entire project in a local environment
to test, which is what I am seeking information on

@lyang2821
Copy link
Collaborator

Lapdev-Dashboard & Api is all you needed to run to add oauth provider support.

Are you running dashboard via Trunk?

@gitizenss
Copy link

I tried this myself and got burnt out. Biggest pain point: running lapdev shouldn't require background systemctl service in order to work. It makes things complicated.

Docker has the docker.service, but it also has dockerd, which doesn't exit immediately, so you can see what's going on.

This project would benefit a lot from a straightforward way to build it and develop on top of it. Right now it's very unlikely to attract contributors due to this alone, in my opinion.

@lyang2821
Copy link
Collaborator

I tried this myself and got burnt out. Biggest pain point: running lapdev shouldn't require background systemctl service in order to work. It makes things complicated.

Docker has the docker.service, but it also has dockerd, which doesn't exit immediately, so you can see what's going on.

This project would benefit a lot from a straightforward way to build it and develop on top of it. Right now it's very unlikely to attract contributors due to this alone, in my opinion.

We'll improve our devcontainer config in Lapdev repo, so that development is easier. (It should be since one of the purpose of Lapdev is to make on boarding easier.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants