Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose View::default_compute_layout #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timboudreau
Copy link
Contributor

While this method is implementable in custom component by copy-paste programming, it would be preferable for custom components to be able to keep up with any changes in the default implementation by calling it directly instead.

While this method *is* implementable in custom component by copy-paste programming,
it would be preferable for custom components to be able to keep up with any changes
in the default implementation by calling it directly instead.
@dzhou121
Copy link
Contributor

dzhou121 commented Jun 3, 2024

maybe we can put the method under ComputeLayoutCx and call it compute_view_children_layout?

@timboudreau
Copy link
Contributor Author

Sure, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants