Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebound on mac #46

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Fix rebound on mac #46

merged 6 commits into from
Jan 22, 2025

Conversation

adamdempsey90
Copy link
Collaborator

Background

This should fix the linking issues on mac. Essentially we don't try in cmake, and instead just run install_name_tool after the build completes to set the @rpath in the binary directly. Because of this change, we also no longer need to move librebound.so after building it, so I got rid of that step too.

With this, I can now successfully execute artemis from anywhere and move the binary anywhere and execute it.

I also added the -Wno-deprecated-declarations to suppress the warnings from singularity.

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this locally on my mac (via disk_collisions.in) and it worked! Nice find (albeit I have no idea what this new cmake nonsense is actually doing...)

@adamdempsey90 adamdempsey90 merged commit bf19cdb into develop Jan 22, 2025
4 checks passed
@adamdempsey90 adamdempsey90 deleted the dempsey/cmake_mac branch January 22, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants