-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account delete #11829
Open
GareArc
wants to merge
29
commits into
main
Choose a base branch
from
feat/account-deletion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: account delete #11829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GareArc
force-pushed
the
feat/account-deletion
branch
3 times, most recently
from
December 21, 2024 20:14
c811260
to
7365883
Compare
GareArc
force-pushed
the
feat/account-deletion
branch
from
December 23, 2024 07:40
c46037c
to
d9bba39
Compare
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Dec 23, 2024
dosubot
bot
added
💪 enhancement
New feature or request
📚 documentation
Improvements or additions to documentation
labels
Dec 23, 2024
GarfieldDai
reviewed
Dec 24, 2024
GarfieldDai
reviewed
Dec 25, 2024
api/services/account_service.py
Outdated
@@ -201,6 +207,10 @@ def create_account( | |||
from controllers.console.error import AccountNotFound | |||
|
|||
raise AccountNotFound() | |||
|
|||
if dify_config.BILLING_ENABLED and BillingService.is_email_in_freeze(email): | |||
raise AccountRegisterError("Email is in freeze.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- SaaS 只有 Github / Google / 邮箱验证码注册账号
- 文案调整为「Unable to re-register the account because the deletion occurred less than 30 days ago.」
- 登录 / 邀请都加入逻辑判断,未满 30 天不允许新建账号
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📚 documentation
Improvements or additions to documentation
💪 enhancement
New feature or request
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods