Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: account delete #11829

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

feat: account delete #11829

wants to merge 29 commits into from

Conversation

GareArc
Copy link
Contributor

@GareArc GareArc commented Dec 19, 2024

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@GareArc GareArc force-pushed the feat/account-deletion branch 3 times, most recently from c811260 to 7365883 Compare December 21, 2024 20:14
@GareArc GareArc force-pushed the feat/account-deletion branch from c46037c to d9bba39 Compare December 23, 2024 07:40
@GareArc GareArc marked this pull request as ready for review December 23, 2024 07:57
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 23, 2024
@GareArc GareArc requested a review from GarfieldDai December 23, 2024 07:57
@dosubot dosubot bot added 💪 enhancement New feature or request 📚 documentation Improvements or additions to documentation labels Dec 23, 2024
@@ -201,6 +207,10 @@ def create_account(
from controllers.console.error import AccountNotFound

raise AccountNotFound()

if dify_config.BILLING_ENABLED and BillingService.is_email_in_freeze(email):
raise AccountRegisterError("Email is in freeze.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. SaaS 只有 Github / Google / 邮箱验证码注册账号
  2. 文案调整为「Unable to re-register the account because the deletion occurred less than 30 days ago.」
  3. 登录 / 邀请都加入逻辑判断,未满 30 天不允许新建账号

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 💪 enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants