New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: storage get non-existent key will not raise error #6

Draft

hjlarry wants to merge 1 commit into langgenius:main from hjlarry:p1

hjlarry commented Dec 22, 2024

when we use item.get(key) method of a python dict or redis, it will not raise error.

So I think the interface should keep consistency.

Then we can use

if item:= self.session.storage.get(key):
    ...

instead of try...catch...


          storage get non-existent key will not raise error

6a05b07

hjlarry marked this pull request as draft

December 23, 2024 02:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet