feat: Add state-modifying retry policies #2957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also as I understand the State/task input can be any type? If that is not the case I would also appreciate some guidance on that |
|
Hello @nfcampos , |
nfcampos
reviewed
Jan 24, 2025
| elif isinstance(retry_policy.retry_on, dict): | ||
| exception_handler = retry_policy.retry_on.get(type(exc), False) | ||
| if callable(exception_handler): | ||
| exception_handler(task.input, exc) |
There was a problem hiding this comment.
missing else branch here?
There was a problem hiding this comment.
Hello @nfcampos,
Thank you for your review.
I fixed it and pushed the changes.
I apologize for this oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add state-modifying retry policies
Description
This PR adds support for state-modifying retry policies by allowing a dictionary mapping of exceptions to state-modifying functions in the RetryPolicy class. This enhancement enables users to modify the workflow state before retry attempts based on specific exceptions.
I think this feature can be very usefull as I am not the only one who needs it. See this discussion
Changes
RetryPolicy'sretry_onparameter to acceptdict[Type[Exception], Callable[[Any, Exception], None]]Tests
I have not added a test for this feature as I did not find a a fitting file name for this case and did not want to make my own test file.
If needed I can add a test for this new feature, I would appreciate guidance on the preferred location for adding tests.
All existing tests pass.