Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38: Update legacy versions #40

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

christopher-b
Copy link
Collaborator

Fixes #38

  • Consider v2.6 and 3.0 legacy
  • Update documentation to indicate new legacy versions
  • Update documentation use the most recent version in examples
  • Add note to documentation regarding maintenance of version 2.7 as the default
  • Update CHANGELOG

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

* Consider v2.6 and 3.0 legacy
* Update documentation to indicate new legacy versions
* Update documentation use the most recent version in examples
* Add note to documentation regarding maintenance of version 2.7 as the
default
* Update CHANGELOG
Copy link

netlify bot commented Oct 13, 2024

👷 Deploy request for lando-ruby pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 365bbea

@christopher-b christopher-b changed the title Update legacy versions #38: Update legacy versions Oct 13, 2024
@christopher-b
Copy link
Collaborator Author

I'm not sure why those "should not serve port 80 for cli" tests are failing; they pass locally. Investigating.

@reynoldsalec
Copy link
Member

We saw the same thing over on nginx, see this comment for the solution @christopher-b: lando/nginx#63 (comment)

@reynoldsalec
Copy link
Member

Only comment I have on the code: if you can use past tense ("Updated" vs "Update") on the Changelog you'll make Pirog happy...he got me to submit on that after many harangues.

@christopher-b
Copy link
Collaborator Author

Done and done!

@reynoldsalec reynoldsalec merged commit 65b402a into lando:main Oct 16, 2024
6 of 7 checks passed
@christopher-b christopher-b deleted the 38-update-versions branch January 9, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported versions
2 participants