Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove laminas-modulemanager support #384

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 31, 2024

Q A
BC Break yes

Description

Removes module manager support in the validator plugin manager factory and in the shipped Module class.

Also removes ValidatorProviderInterface which is used exclusively in MVC related code.

Possibly closes #336

@gsteel gsteel added this to the 3.0.0 milestone Jul 31, 2024
@gsteel gsteel force-pushed the v3/remove-module-manager-support branch from 061f1c4 to 6339238 Compare July 31, 2024 12:55
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me. 👍🏻

@gsteel gsteel self-assigned this Aug 1, 2024
@gsteel gsteel force-pushed the v3/remove-module-manager-support branch from 6339238 to e291698 Compare August 1, 2024 09:48
@gsteel gsteel merged commit 72ef168 into laminas:3.0.x Aug 1, 2024
14 of 15 checks passed
@gsteel gsteel deleted the v3/remove-module-manager-support branch August 1, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Drop Support for MVC in 3.0 so it can be added later without a BC break
2 participants