Reduce use of deprecated Laminas\ServiceManager\ConfigInterface #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all uses except HelperConfig, which inherits so removal would be a breaking change Signed-off-by: ramchale <[email protected]>
ramchale
force-pushed
the
reduce-deprecated-Config
branch
from
c472771 to
e6d0d4c
Compare
samsonasik
approved these changes
Oct 21, 2024
gsteel
approved these changes
Oct 22, 2024
| @@ -157,13 +156,12 @@ public function testTranslate(): void | |||
| { | |||
| $loader = new TestLoader(); | |||
| $loader->textDomain = new TextDomain(['foo' => 'bar']); | |||
| $config = new Config([ | |||
| $pm = $this->translator->getPluginManager(); | |||
There was a problem hiding this comment.
@ramchale
For the future: Please use meaningful names and no abbreviations like these. Also in tests.
Thanks in advance! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Laminas\ServiceManager\ConfigInterface is deprecated and removed in laminas/laminas-servicemanager v4.
Removing all uses except HelperConfig (which inherits so removal would be a breaking change) to make any future upgrade slightly easier.