Merge pull request #222 from lambdaisland/arne/dont-hide-load-error

Don't let the "no tests found" message shadow the load error
lambdaisland · May 7, 2021 · 3d83494 · 3d83494
2 parents 8f18bab + 9df982c
commit 3d83494
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/bb_deps.edn b/bb_deps.edn
@@ -1,4 +1,4 @@
 {:deps
  {lambdaisland/open-source {:git/url "https://github.com/lambdaisland/open-source"
-                            :sha "55f81454a62b0688a0702735257cc5473f2f0c60"
+                            :sha "43ea822056ce84017639841ac082b9007a32d0f4"
                             #_#_:local/root "../open-source"}}}
diff --git a/src/kaocha/api.clj b/src/kaocha/api.clj
@@ -98,7 +98,9 @@
           (with-bindings (config/binding-map config)
             (let [config (resolve-reporter config)]
               (let [test-plan (test-plan config)]
-                (when-not (some hierarchy/leaf? (testable/test-seq test-plan))
+                (when-not (some #(or (hierarchy/leaf? %)
+                                     (::testable/load-error %))
+                                (testable/test-seq test-plan))
                   (output/warn (str "No tests were found, make sure :test-paths and "
                                     ":ns-patterns are configured correctly in tests.edn."))
                   (throw+ {:kaocha/early-exit 0}))

diff --git a/test/unit/kaocha/version_check_test.clj b/test/unit/kaocha/version_check_test.clj
@@ -12,10 +12,8 @@
 
 (deftest current-version-does-not-throw
   (is (nil? (binding [*clojure-version* {:major 1 :minor 9}]
-        (v/check-version-minimum 1 9)))))
-
+              (v/check-version-minimum 1 9)))))
 
 (deftest version-2-does-not-throw
   (is (nil? (binding [*clojure-version* {:major 2 :minor 0}]
-        (v/check-version-minimum 1 9)))))
-
+              (v/check-version-minimum 1 9)))))