Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

ci: add release workflow #73

Merged
merged 1 commit into from
Aug 11, 2023
Merged

ci: add release workflow #73

merged 1 commit into from
Aug 11, 2023

Conversation

d-roak
Copy link
Contributor

@d-roak d-roak commented Jul 31, 2023

Added docker build and publish to gh registry on release

@lferrigno lferrigno requested a review from klaus993 August 9, 2023 13:43
Copy link
Contributor

@klaus993 klaus993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, did you test it somehow @d-roak ? Either way, as this is triggered manually, we can just merge and test it afterwards.

The only extra consideration I'd make is that we have 50GB of included GH Registry storage. I will monitor this and let you know if there is any issue with storage or costs.

@d-roak
Copy link
Contributor Author

d-roak commented Aug 9, 2023

This looks great, did you test it somehow @d-roak ? Either way, as this is triggered manually, we can just merge and test it afterwards.

Yep, it's the workflow I created for Madara

The only extra consideration I'd make is that we have 50GB of included GH Registry storage. I will monitor this and let you know if there is any issue with storage or costs.

Do you know what is the docker image current size? We can deprecate older images, while keeping the release tag, so people can build them

@fkrause98 fkrause98 merged commit bc1d87e into main Aug 11, 2023
1 check passed
@fkrause98 fkrause98 deleted the ci/release-workflow branch August 11, 2023 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants