Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine serialization #687

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Affine serialization #687

merged 7 commits into from
Dec 18, 2023

Conversation

mb-dci
Copy link
Contributor

@mb-dci mb-dci commented Nov 16, 2023

Add uncompressed affine serialization to ShortWeierstrassProjectivePoint

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6063197) 95.77% compared to head (1101187) 95.79%.

Files Patch % Lines
math/src/elliptic_curve/short_weierstrass/point.rs 99.35% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   95.77%   95.79%   +0.01%     
==========================================
  Files         135      135              
  Lines       30136    30248     +112     
==========================================
+ Hits        28863    28975     +112     
  Misses       1273     1273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dndll
Copy link

dndll commented Nov 17, 2023

Relates to #684

@mb-dci mb-dci marked this pull request as ready for review November 27, 2023 14:43
@mb-dci mb-dci requested review from schouhy, ajgara and a team as code owners November 27, 2023 14:43
@Oppen Oppen added this pull request to the merge queue Dec 18, 2023
Merged via the queue into lambdaclass:main with commit b284c34 Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants