EVM implement CALL opcode #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More rigourous checks are needed
jrchatruc
approved these changes
Apr 18, 2024
jrchatruc
added a commit
that referenced
this pull request
Apr 29, 2024
* feat(call-opcode): Implement CALL More rigourous checks are needed * fix(call-opcode): fix Merge * feat(call-opcode): Add function _isEVM() * feat(call-opcode): Add function _pushEVMFrame() and _popEVMFrame() * feat(gas-related-function): Add gas related functions, needed for OP_CALL * chore: indent properly * feat(verbatims-functions): Add verbatims * feat(call-related-functions): Add _saveReturnDataAfterZkEVMCall() * feat(call-related-functions): Add _performCall() // Stack depth errors (WIP) * Fix stack too deep error * chore(remove dead code): Remove _performCall() * chore(copy code): Copy code inside the two objects * fix(call tests): Fix selector store inside _isEVM() * fix(call tests): Fix constants and Add prints (WIP) --------- Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: Manuel Bilbao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More rigourous checks are needed
What ❔
Implement
CALLopcode.Why ❔
Checklist