-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: share constants between Program
instances
#1442
Draft
Oppen
wants to merge
3
commits into
main
Choose a base branch
from
perf/share_constants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces `Program` cloning for building the `CairoRunner` by 86% according to our Criterion benchmarks. This is a significant cost for running many short-lived programs such as most Starknet transactions. No negative impact in runtime was observed.
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
September 11, 2023 14:11
Codecov Report
@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 96.98% 96.98% -0.01%
==========================================
Files 93 93
Lines 38637 38636 -1
==========================================
- Hits 37474 37473 -1
Misses 1163 1163
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
Interestingly this shows a slowdown. I guess I'll have to run the benchmarks again in the server and my workstation just in case. Converting to draft in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces
Program
cloning for building theCairoRunner
by 86%according to our Criterion benchmarks.
Running transactions 68000-68500 with Pathfinder shows a 7% improvement.
Checklist