Add support for multiple engine #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykaul
reviewed
Sep 3, 2018
ovirtlago/virt.py
Outdated
| cpu_family = self.get_ovirt_cpu_family() | ||
| api = self.engine_vm().get_api_v4(check=True) | ||
| api = self.engine_vm()[idx].get_api_v4(check=True) |
There was a problem hiding this comment.
Should that be engine_vms() and not engine_vm() ?
There was a problem hiding this comment.
@galitf was this comment addressed?
galitf
force-pushed
the
support_more_engine
branch
from
386089c
to
9a964eb
Compare
|
ci test please |
galitf
force-pushed
the
support_more_engine
branch
5 times, most recently
from
23084cb
to
261418a
Compare
Signed-off-by: Galit <[email protected]>
galitf
force-pushed
the
support_more_engine
branch
from
261418a
to
5280615
Compare
|
ci test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Galit [email protected]