Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes detected with CDash ci and reverting changes around buildFrom() functions to make them no more deprecated #1478

Merged
merged 24 commits into from
Oct 8, 2024

Conversation

fspindle
Copy link
Contributor

@fspindle fspindle commented Oct 8, 2024

No description provided.

…g ‘/’ or ‘%’ to ‘>>’ or ‘&’ [-Wstrict-overflow] due to stb_truetype.h 3rd party
… or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
by reintroducing buildFrom() functions that allows now chaining calls
instead of having buildFrom() deprecated and a new function build() for chaining calls
…mand-line option ‘-Wno-inconsistent-missing-override’ may have been intended to silence earlier diagnostics
…mand-line option ‘-Wno-unqualified-std-cast-call’ may have been intended to silence earlier diagnostics
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 128 lines in your changes missing coverage. Please review.

Project coverage is 54.02%. Comparing base (d771eb5) to head (e320816).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
...ore/src/math/transformation/vpForceTwistMatrix.cpp 25.00% 12 Missing ⚠️
.../src/math/transformation/vpVelocityTwistMatrix.cpp 47.05% 9 Missing ⚠️
...ules/core/src/math/transformation/vpRzyxVector.cpp 38.46% 8 Missing ⚠️
...ules/core/src/math/transformation/vpRzyzVector.cpp 38.46% 8 Missing ⚠️
...es/core/src/math/transformation/vpThetaUVector.cpp 68.00% 8 Missing ⚠️
...re/src/math/transformation/vpHomogeneousMatrix.cpp 53.33% 7 Missing ⚠️
...ules/core/src/math/transformation/vpRxyzVector.cpp 53.84% 6 Missing ⚠️
.../vision/src/homography-estimation/vpHomography.cpp 33.33% 6 Missing ⚠️
...odules/core/include/visp3/core/vpImage_operators.h 28.57% 5 Missing ⚠️
...ore/src/math/transformation/vpQuaternionVector.cpp 58.33% 5 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   54.02%   54.02%   -0.01%     
==========================================
  Files         442      442              
  Lines       50842    50847       +5     
==========================================
+ Hits        27467    27469       +2     
- Misses      23375    23378       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit f83e271 into lagadic:master Oct 8, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant