Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements in vpCircleHoughTransform #1224

Merged
merged 6 commits into from
Sep 2, 2023

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Sep 1, 2023

  • Renamed the CHTParameters subclass into vpCircleHoughTransformParameters to follow ViSP naming convention
  • If ViSP is compiled without OpenCV imgproc module, use expressly the vpCannyEdgeDetector class in edgeDetection in order to compute the gradients only once
  • Fine tuned some parameters in the tutorial in case ViSP is compiled without OpenCV imgproc module ( NB : the detection is not perfect with the quarter disks in this case)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (b0b82db) 54.34% compared to head (63902af) 54.37%.
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   54.34%   54.37%   +0.02%     
==========================================
  Files         405      405              
  Lines       49822    49827       +5     
==========================================
+ Hits        27078    27093      +15     
+ Misses      22744    22734      -10     
Files Changed Coverage Δ
modules/core/include/visp3/core/vpImageCircle.h 0.00% <ø> (ø)
...roc/include/visp3/imgproc/vpCircleHoughTransform.h 0.00% <0.00%> (ø)
modules/imgproc/src/vpCircleHoughTransform.cpp 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 76cc08f into lagadic:master Sep 2, 2023
56 of 58 checks passed
@rolalaro rolalaro deleted the vpCircleHoughTransform branch October 5, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants