Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer std:: functions when available rather than non std functions #1220

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

fspindle
Copy link
Contributor

Allows to fix build on ubuntu 12.04 ci:
modules/core/src/math/misc/vpMath.cpp:181:24: error: ‘isfinite’ was not declared in this scope

Allows to fix build on ubuntu 12.04 ci:
modules/core/src/math/misc/vpMath.cpp:181:24: error: ‘isfinite’ was not declared in this scope
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (83555f3) 54.98% compared to head (305b4a6) 54.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   54.98%   54.97%   -0.01%     
==========================================
  Files         399      399              
  Lines       49201    49201              
==========================================
- Hits        27051    27048       -3     
- Misses      22150    22153       +3     
Files Changed Coverage Δ
modules/core/src/math/misc/vpMath.cpp 95.68% <ø> (ø)
modules/core/include/visp3/core/vpMath.h 93.75% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 553905a into lagadic:master Aug 30, 2023
58 checks passed
@fspindle fspindle deleted the fix_ubuntu_12_04_std branch July 3, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant