Set NOPRED score for CombinedPredictor to 0.5 eppic-team#161

Because it is a probability, the NOPRED score should be the most uncertain value.
lafita · Jan 30, 2017 · 7082dc3 · 7082dc3
1 parent 3337004
commit 7082dc3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/eppic-cli/src/main/java/eppic/predictors/CombinedClusterPredictor.java b/eppic-cli/src/main/java/eppic/predictors/CombinedClusterPredictor.java
@@ -11,8 +11,8 @@ public class CombinedClusterPredictor implements InterfaceTypePredictor {
 	private CallType call;
 	private String callReason;
 
-	private double probability;
-	private double confidence;
+	private double probability = 0.5;
+	private double confidence = 0.5;
 
 
 	public CombinedClusterPredictor(List<CombinedPredictor> lcp) {
@@ -69,7 +69,7 @@ public double getScore() {
 	}
 
 	@Override
-	public double getScore1() {		
+	public double getScore1() {
 		return SCORE_UNASSIGNED;
 	}
 
@@ -93,7 +93,7 @@ private void calcConfidence() {
 			confidence = 1 - probability;
 			break;
 		case NO_PREDICTION: 
-			confidence = CONFIDENCE_UNASSIGNED;
+			confidence = 0.5;
 
 		}
 

diff --git a/eppic-cli/src/main/java/eppic/predictors/CombinedPredictor.java b/eppic-cli/src/main/java/eppic/predictors/CombinedPredictor.java
@@ -47,8 +47,8 @@ public class CombinedPredictor implements InterfaceTypePredictor {
 
 	private CallType call;
 
-	private double probability;
-	private double confidence;
+	private double probability = 0.5;
+	private double confidence = 0.5;
 
 	public CombinedPredictor(InterfaceEvolContext iec, 
 			GeometryPredictor gp, EvolCoreRimPredictor ecrp, EvolCoreSurfacePredictor ecsp) {
@@ -106,7 +106,7 @@ public void computeScores() {
 			LOGGER.info("Interface {} is not protein in either side, can't score it",iec.getInterface().getId());
 			callReason = "Both sides are not protein, can't score";
 			call = CallType.NO_PREDICTION;
-			probability = -1;
+			probability = 0.5;
 			return;
 		}
 
@@ -186,7 +186,7 @@ private void calcConfidence() {
 			confidence = 1 - probability;
 			break;
 		case NO_PREDICTION:
-			confidence = CONFIDENCE_UNASSIGNED;
+			confidence = 0.5;
 
 		}