-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix sudo -E bash -c '$cmd' with cmd that contains single quotations #4427
Conversation
Signed-off-by: daymade <[email protected]>
|
🤖 Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4427 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
@bxy4543 I'm currently addressing the failed end-to-end tests. I've discovered that docker_122 and docker_123 have failed, while containerd_122 and containerd_123 are functioning correctly. The issue appears to be related to an older version of Kubernetes running with the Docker runtime. I would greatly appreciate any tips or advice for debugging this problem. E2E_sealos_runtime_version_docker_123_test failed log for E2E_sealos_runtime_version_docker_123_test
log for E2E_sealos_runtime_version_docker_124_test
log for E2E_sealos_runtime_version_123_test
|
@daymade |
this is a bug fix for #4424 ,
the cmd of metrics-server in cluster's yaml has a signle quotation
'
in--set args='{--kubelet-insecure-tls=true,--kubelet-preferred-address-types=InternalIP}'
, which will cause a problem with the single quotation insudo -E /bin/bash -c '$cmd'
if we find a cmd to wrap that contains single quotations, we can replace it with double quotations to avoid problems.