Add classes for cards and positions #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds and integrates `org-fc-card`, `org-fc-position`, `org-fc-review-session`, and `org-fc-review-session-rating` classes.
Adds `org-fc-review-position-filters` which users can configure to customize the positions that appear in their review. Example use cases: - Limit the number of new positions per review - Only include one position with a specific tag - Only include one position per file
Use a box value of -1 to indicate a new (never been reviewed) position.
Consider three cards: 1. card-A with an ID of `card-a-id` 1. card-B with an ID of `card-b-id` 1. card-C with an ID of `card-c-id` The user can set card-B as blocking card-A and card-C by setting the `FC_BLOCKED_BY` property on cards A and B to `card-b-id`. Alternatively, the user could set card-A and card-B as blocking card-C by setting the `FC_BLOCKED_BY` property on card-C to `card-a-id,card-b-id`.
|
Closing this pull request; will re-open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94.
Re-issuing this pull request due to conversation in #106.
Note that there are merge conflicts with
developfrom 4487630 and 073bfef that I've yet to resolve. Submitting the pull request anyway to give a space for conversation regarding the new classes.