nexusmods-app: refactor tests declaration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Don't include upstream's 7zz binary - Tell the app it is a distro package - Document more of the build configuration - Format using nixfmt-rfc-style Closes NixOS#317852. Co-authored-by: Matt Sturgeon <[email protected]>
l0b0
force-pushed
the
nexusmods-app-update
branch
from
7fb2db9 to
3e9797d
Compare
l0b0
force-pushed
the
nexusmods-app-update
branch
6 times, most recently
from
bd88aa6 to
8e951c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all our tests follow the same pattern, we can declare using
mapAttrsIDK if this is really relevant to the version bump, but I guess it's better to have small changes like this included in the more important PRs, as such changes wouldn't be worth reviewing in a dedicated PR?