[pull] develop from cycfi:develop #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- added sin variants accuracy tests
Fixes android ndk-build "duplicate symbol" error. "inline" may not have been added on purpose or accidentally. I am not expert with this (c++17). But seems like fixing android ndk build while don't broke Windows build. It should be evaluated by a specialist before commit. Error message in ndk-build without "inline": ld: error: duplicate symbol: cycfi::q::soft_knee_compressor::threshold(cycfi::q::decibel) >>> defined at dynamic.hpp:192 (./include\q/fx\dynamic.hpp:192)
fix missing "inline" in dynamic.hpp for android ndk-build
- Fixed missing header
Warning fixes
Fix member initialization order in noise_gate
djowel
force-pushed
the
develop
branch
3 times, most recently
from
56a29b5
to
f14d5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )