Fixes issue #90: added support for Cppcheck result containing file "n…

…ofile" and line-number "0"
kwin · Nov 29, 2018 · 9435690 · 9435690
1 parent b5ffbf7
commit 9435690
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...heclipse.core.tests/src/com/googlecode/cppcheclipse/core/command/TestCppcheckCommand.java b/...heclipse.core.tests/src/com/googlecode/cppcheclipse/core/command/TestCppcheckCommand.java
@@ -40,6 +40,10 @@ public void testParseResultLines() throws Exception {
 		String line3 = ";;information;missingInclude;Cppcheck cannot find all the include files (use --check-config for details)";
 		Problem problem3 = CppcheckCommand.parseResult(line3, null);
 		assertProblem(problem3, null, -1, "information", "missingInclude", "Cppcheck cannot find all the include files (use --check-config for details)");
+
+		String line4="nofile;0;information;missingInclude;Cppcheck cannot find all the include files (use --check-config for details)";
+		Problem problem4 = CppcheckCommand.parseResult(line4, null);
+		assertProblem(problem4, null, -1, "information", "missingInclude", "Cppcheck cannot find all the include files (use --check-config for details)");
 	}
 
 	private void assertProblem(Problem problem, File file, int line,  String category, String id,  String message) {

diff --git a/...ecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/CppcheckCommand.java b/...ecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/command/CppcheckCommand.java
@@ -297,14 +297,14 @@ public static Problem parseResult(String line, IProject project) {
 		try {
 
 			File filename;
-			if (Strings.isNullOrEmpty(lineParts[0])) {
+			if (Strings.isNullOrEmpty(lineParts[0]) || "nofile".equals(lineParts[0])) {
 				filename = null;
 			} else {
 				filename = new File(lineParts[0]);
 			}
 			// if line is empty set it to -1
 			int lineNumber;
-			if (Strings.isNullOrEmpty(lineParts[1])) {
+			if (Strings.isNullOrEmpty(lineParts[1]) || "0".equals(lineParts[1])) {
 				lineNumber = -1;
 			} else {
 				lineNumber = Integer.parseInt(lineParts[1]);