feat: set service image in em ui #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
changed the title
tedim52
changed the title
tedim52
force-pushed
the
tedi/setserviceui
branch
from
ed38636 to
2067e4c
Compare
tedim52
force-pushed
the
tedi/setserviceui
branch
from
2067e4c to
f06a88e
Compare
tedim52
force-pushed
the
tedi/setserviceui
branch
from
dc35573 to
b86f515
Compare
tedim52
commented
Apr 30, 2024
enclave-manager/web/packages/app/src/emui/enclaves/components/widgets/ImageButton.tsx
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Apr 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.1](0.89.0...0.89.1) (2024-04-30) ### Features * adding enclave production mode value in the APIC primitive ([#2407](#2407)) ([86acc7f](86acc7f)) * set service image in em ui ([#2406](#2406)) ([917f011](917f011)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2024
## Description Fixes how args are parsed and passing into script that updates images. Also fixes logic with how `initialSerializedParams` are set. ## Is this change user facing? NO ## References #2406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds UI button for setting service image using
set_serviceinstruction.https://www.loom.com/share/c6e87488214047c782bbffb1d3fa0bb5
Is this change user facing?
YES
References
#2372