remove class options as mandatory

kumar1202 · Sep 15, 2024 · 602184f · 602184f
1 parent 90e8221
commit 602184f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/lib/gojira/command/cluster.rb b/lib/gojira/command/cluster.rb
@@ -8,11 +8,11 @@ class Cluster < Gojira::Command::Base
       REQUIRED_CLASS_OPTIONS = %i[tls_enabled]
 
       desc "validate", "validates kong config for a cluster"
-      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: true
-      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: true
-      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: true
-      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: true
-      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: true
+      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: false
+      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: false
+      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: false
+      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: false
+      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: false
       def validate
         validate_options
         deck = Gojira::Deck::Gateway.new('deck', get_control_plane)
@@ -23,11 +23,11 @@ def validate
       end
 
       desc "diff", "diff output for kong config in a cluster"
-      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: true
-      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: true
-      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: true
-      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: true
-      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: true
+      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: false
+      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: false
+      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: false
+      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: false
+      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: false
       def diff
         validate_options
         deck = Gojira::Deck::Gateway.new('deck', get_control_plane)
@@ -38,11 +38,11 @@ def diff
       end
 
       desc "sync", "syncs kong config to a cluster"
-      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: true
-      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: true
-      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: true
-      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: true
-      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: true
+      method_option :kong_state_file, aliases: '-s', type: :string, desc: 'Kong State File', required: false
+      method_option :env_name, aliases: '-n', type: :string, desc: 'Environment identifier name', required: false
+      method_option :compliance_type, aliases: '-c', type: :string, desc: 'Compliance Type', enum: ['pci', 'non-pci'], required: false
+      method_option :cluster_file, aliases: '-f', type: :string, desc: 'Cluster file path', required: false
+      method_option :dc_name, aliases: '-d', type: :string, desc: 'DC Name', required: false
       def sync
         require 'pry'; binding.pry
         validate_options

diff --git a/spec/lib/gojira/cli_spec.rb b/spec/lib/gojira/cli_spec.rb
@@ -27,7 +27,7 @@
       expect_any_instance_of(Gojira::Command::Cluster).to receive(:sync)
       cli.options = {kong_state_file: "state.yaml", env_name: "production", compliance_type: "pci", cluster_file: "clusters.yaml", dc_name: "nm"}
       #require 'pry'; binding.pry
-      cli.invoke('cluster', ["sync --kong-state-file='anc.yaml'"], {kong_state_file: "state.yaml", env_name: "production", compliance_type: "pci", cluster_file: "clusters.yaml", dc_name: "nm"})
+      cli.invoke('cluster', ["sync"], {kong_state_file: "state.yaml", env_name: "production", compliance_type: "pci", cluster_file: "clusters.yaml", dc_name: "nm"})
     end
   end