Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xds): fix token expiration issue caused by inappropriate cache in kuma-cp #12782

Open
wants to merge 2 commits into
base: release-2.9
Choose a base branch
from

Conversation

jijiechen
Copy link
Member

Motivation

An inappropriate cache of the auth result may cause incorrect auth result between DP and CP.

Implementation information

Only auth once per gRPC stream.

Supporting documentation

Fix #XX

}
if err := a.authenticator.Authenticate(user.Ctx(s.ctx, user.ControlPlane), s.resource, credential); err != nil {
return errors.Wrap(err, "authentication failed")
// If the gRPC stream is already authenticated, we don't need to authenticate it again.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't put it in OnStreamOpen because we don't have the resource object in there.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@jijiechen
Copy link
Member Author

fix defaulting behaviour of EnableReloadableTokens on CP config

@lukidzi
Copy link
Contributor

lukidzi commented Feb 7, 2025

We should target master and backport to other branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants