-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rules): organize code in the packages, prepare for inbound rules #12559
base: master
Are you sure you want to change the base?
Conversation
…ules Signed-off-by: Ilya Lobkov <[email protected]>
@@ -0,0 +1,339 @@ | |||
package subsetutils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are just copies of functions from rules.go
in this file, you can skip reviewing this
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do proper git mv
? This would greatly simplify this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's already moved where possible, sometimes the code is copied from rules.go
to more specific packages and in this case git mv
won't help
Motivation
rules.go
is insufficientto[i]
hastargetRef
anddefault
fields, whilerules[i]
is going to havedefault
,matches
,targetRef
fields). It's easier to use generics, likemerge
,sort
,common
)Supporting documentation
Check commit to see how new inbound rules are implemented