Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oapi): move CreateOrUpdateSuccessResponse under components.responses #12558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Jan 15, 2025

Motivation

because it makes more sense under there

Implementation information

move the definition

Supporting documentation

closes #12322

@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Jan 15, 2025
@slonka slonka requested a review from a team as a code owner January 15, 2025 09:16
@slonka slonka added ci/skip-e2e-test PR: Don't run e2e tests and removed ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) labels Jan 15, 2025
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@slonka slonka requested review from bartsmykla and lukidzi January 15, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move *CreateOrUpdateSuccessResponse from components.schemas to components.responses
2 participants