-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prod/cp-deployment/multi-zone): hint for each zone create own cluster #2083
Merged
slonka
merged 6 commits into
kumahq:master
from
schogges:feat/prod/cp-deployment/multi-zone/hint_each_zone_own_cluster
Dec 13, 2024
Merged
feat(prod/cp-deployment/multi-zone): hint for each zone create own cluster #2083
slonka
merged 6 commits into
kumahq:master
from
schogges:feat/prod/cp-deployment/multi-zone/hint_each_zone_own_cluster
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster Signed-off-by: schogges <[email protected]>
schogges
requested review from
michaelbeaumont and
slonka
and removed request for
a team
November 13, 2024 09:17
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ch_zone_own_cluster
Signed-off-by: schogges <[email protected]>
slonka
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Q
…ch_zone_own_cluster
…ch_zone_own_cluster
…ch_zone_own_cluster
slonka
approved these changes
Dec 13, 2024
schogges
deleted the
feat/prod/cp-deployment/multi-zone/hint_each_zone_own_cluster
branch
December 16, 2024 11:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first assumed that more than one zone can be created per cluster. Somewhere I could read between the lines that each individual zone requires an own cluster. So in order to have every page is page 1, I think it would be nice to have.