feat(prod/cp-deployment): add hint to restart pods after installation #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schogges <[email protected]>
schogges
requested review from
Automaat and
lobkovilya
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jijiechen
reviewed
Dec 5, 2024
jijiechen
reviewed
Dec 5, 2024
|
Looks good to me basically. Please have a look at the suggestions. |
Co-authored-by: Jay Jijie Chen <[email protected]> Signed-off-by: Mo <[email protected]>
Co-authored-by: Jay Jijie Chen <[email protected]> Signed-off-by: Mo <[email protected]>
michaelbeaumont
approved these changes
Dec 12, 2024
jijiechen
approved these changes
Dec 13, 2024
schogges
deleted the
feat/prod/cp-deployment/hint_restart_pods_after_install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running into this, I think it might be worth to document this.