-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upgrade): embed upgrade.md in docs #1706
Conversation
Fix kumahq#1535 Signed-off-by: Charly Molter <[email protected]>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Charly Molter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but do we now need to use template variables in https://github.com/kumahq/kuma/blob/master/UPGRADE.md so that it renders correctly on both websites?
Rendered: https://deploy-preview-1706--kuma.netlify.app/docs/2.6.x/production/upgrades-tuning/upgrade-notes/ also some links are broken, should we disable link checker on this page? |
I think we'd be better off fixing the links. For the variable the UPGRADE pages are different between Kuma and KM and the one from KM will link to the Kuma docs (see: https://github.com/Kong/kong-mesh/blob/master/UPGRADE.md). It was an easy low effort change. |
This should fix the links: kumahq/kuma#9835 |
CoreDNS website timed out on the last link check and there is a problem with GH anchor that was fixed in main. Let's see if merge fixes it. |
For the links issue: https://github.com/kumahq/kuma-website/pull/1712/files |
Fix #1535
<Explain your change!>
Did you sign your commit? Instructions
Have you read Contributing guidelines?