Bump jekyll-generator-single-source #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@fabianrbz can you rebase seems like there are some conflicts |
fabianrbz
force-pushed
the
refactor-version-is
branch
3 times, most recently
from
3f62a48 to
6215139
Compare
|
@lahabana test is failing due to a caching issue, can you clear the cache for that action? |
fabianrbz
force-pushed
the
refactor-version-is
branch
2 times, most recently
from
a670374 to
df90f88
Compare
fabianrbz
requested review from
Automaat and
bartsmykla
and removed request for
a team
|
@fabianrbz is this ready to review? |
|
@lahabana yes |
|
@fabianrbz - tests are failing, can you look into them? |
|
@fabianrbz are you still looking into this? |
1 similar comment
|
@fabianrbz are you still looking into this? |
fabianrbz
force-pushed
the
refactor-version-is
branch
from
d1f836b to
a1d2d4a
Compare
lahabana
reviewed
Nov 5, 2024
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Remove jekyll-plugins section, list them in the jekyll config file Signed-off-by: Fabian Rodriguez <[email protected]>
Skip versions that are labelled with `dev` Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
fabianrbz
force-pushed
the
refactor-version-is
branch
from
a1d2d4a to
4b054e8
Compare
The generators defined here should have a lower priority than the one defined in jekyll-generator-single-source. Also, medium isn't a valid priority. Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
fabianrbz
force-pushed
the
refactor-version-is
branch
from
acc3c43 to
a20ef07
Compare
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
lahabana
approved these changes
Nov 7, 2024
Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
to kumahq/kuma
that referenced
this pull request
Nov 8, 2024
This fixes: kumahq/kuma-website#2073 which is needed as we moved to the latest site-generator with: kumahq/kuma-website#1623 Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
to kumahq/ci-tools
that referenced
this pull request
Nov 8, 2024
With kumahq/kuma-website#1623 all sites use `label:dev` so it's no longer needed to have a flag for this Signed-off-by: Charly Molter <[email protected]>
This was referenced Nov 8, 2024
lahabana
added a commit
to kumahq/ci-tools
that referenced
this pull request
Nov 8, 2024
With kumahq/kuma-website#1623 all sites use `label:dev` so it's no longer needed to have a flag for this Signed-off-by: Charly Molter <[email protected]>
lahabana
added a commit
to kumahq/kuma
that referenced
this pull request
Nov 8, 2024
## Motivation This fixes: kumahq/kuma-website#2073 which is needed as we moved to the latest site-generator with: kumahq/kuma-website#1623. --------- Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the site to use the new version of
jekyll-generator-single-source.Most notable changes:
/{{ page.release }}/instead of/{{ page.version }}which is more accuratedevrelease changes slightly, instead of having aapp/_data/docs_nav_dev.ymlit needs to be named after the next release, e.g.app/_data/docs_nav_2.6.x.yml. Thedevbit is handled via theapp/_data/versions.ymlfile, by addinglabel: devto the corresponding version.This also updates:
make clean && make runbuilds and runs the site, including redirectsDid you sign your commit? Instructions
Have you read Contributing guidelines?