docs(policy): improve targetRef table #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaelbeaumont
force-pushed
the
docs/mal-table
branch
2 times, most recently
from
6286110 to
0697a8e
Compare
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
docs/mal-table
branch
from
0697a8e to
795c7e5
Compare
michaelbeaumont
requested review from
johncowen and
kleinfreund
and removed request for
a team
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
docs/mal-table
branch
from
678f4c9 to
357f100
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
docs/mal-table
branch
from
357f100 to
a370384
Compare
michaelbeaumont
changed the title
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
docs/mal-table
branch
from
3e988f0 to
213fae9
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
|
You'll want to update: https://deploy-preview-1579--kuma.netlify.app/docs/dev/policies/targetref/#target-resources But the docs look good |
Signed-off-by: Mike Beaumont <[email protected]>
Updated it, WDYT? |
lahabana
reviewed
Jan 22, 2024
lahabana
reviewed
Jan 22, 2024
There was a problem hiding this comment.
LGTM but you need to at least conditionally render the targetRef.md or update also old tables to new style.
Also really feels like this could be generated and extracted in some ways from the schema to keep them in tight sync and avoid all this conditional rendering. (That's for sure out of scope though :) )
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
lahabana
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.