Move raw files from app/docs to app/assets/<version>/raw/
#1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianrbz
requested review from
michaelbeaumont and
bartsmykla
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fabianrbz
force-pushed
the
fix-raw-assets
branch
from
8712394 to
fdc3fb7
Compare
5 tasks
lahabana
reviewed
Dec 18, 2023
They are being processed by Jekyll and converted into html Signed-off-by: Fabian Rodriguez <[email protected]>
Signed-off-by: Fabian Rodriguez <[email protected]>
Add `mesh_raw_generated_paths` to jekyll.yml and jekyll-dev.yml Signed-off-by: Fabian Rodriguez <[email protected]>
fabianrbz
force-pushed
the
fix-raw-assets
branch
from
3649c73 to
f96f2d2
Compare
|
@lahabana anything else caught your eye or is it ok to merge? |
lahabana
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move raw files from
app/docstoapp/assets/<version>/raw/They were being processed by Jekyll and converted into HTML files. This change prevents that from happening as they are now considered static files.
This also updates the plugins so that they use the new paths.
I don't think we need redirects for this, because afaik these were used internally to embed files in pages.
@lahabana WDYT?
TODO:
We'll need to update the github action so that it adds the files to the new path, and update docs.konghq.com accordingly.Did you sign your commit? Instructions Y
Have you read Contributing guidelines? Y