Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(vale): try to reduce linter noise #1551

Merged
merged 1 commit into from
Jan 18, 2024
Merged

ci(vale): try to reduce linter noise #1551

merged 1 commit into from
Jan 18, 2024

Conversation

lahabana
Copy link
Contributor

No description provided.

@lahabana lahabana requested a review from a team as a code owner December 11, 2023 09:18
@lahabana lahabana requested review from lobkovilya and lukidzi and removed request for a team December 11, 2023 09:18
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit ce36aff
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6576d3ed90b2940008d04a9d
😎 Deploy Preview https://deploy-preview-1551--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

michaelbeaumont
michaelbeaumont approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for links? My suspicion is that vale is somehow just misconfigured because it's made for markdown, it can't be that it doesn't understand links, right?
But if it works it works.

@michaelbeaumont
Copy link
Contributor

@lahabana should we merge this?

@lahabana lahabana merged commit dfcd4b1 into kumahq:master Jan 18, 2024
14 checks passed
@kong-docs kong-docs mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-website-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-website-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @michaelbeaumont