Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(policies): reminder for using snakeCase #1539

Merged
merged 2 commits into from
Dec 4, 2023
Merged

docs(policies): reminder for using snakeCase #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffbac01
docs(policies): reminder for using snakeCase
jakubdyszkiewicz Nov 30, 2023
81537c9
make vale happy
jakubdyszkiewicz Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/_src/policies/meshproxypatch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ spec:
origin: inbound # optional: if absent, all clusters regardless of its origin will be patched
jsonPatches: # optional and mutually exclusive with "value": list of modifications in JSON Patch notation
- op: add
path: /transportSocket/typedConfig/commonTlsContext/tlsParams
path: /transportSocket/typedConfig/commonTlsContext/tlsParams # remember to always use camelCase
value:
tlsMinimumProtocolVersion: TLSv1_2
- op: add
Expand Down Expand Up @@ -1473,6 +1473,10 @@ All modifications from `appendModification` list are always merged.
For example, if there is a policy with `targetRef.kind: Mesh` and second policy with `targetRef.kind: MeshService` that matches a data plane proxy,
all modifications from both policies will be applied.

## Json patch
jakubdyszkiewicz marked this conversation as resolved.
Show resolved Hide resolved
jakubdyszkiewicz marked this conversation as resolved.
Show resolved Hide resolved

If you use json patch, remember to always use _snakeCase_ instead of _camel_case_ in `path` parameter even though you see _camel_case_ in Envoy Config Dump.
jakubdyszkiewicz marked this conversation as resolved.
Show resolved Hide resolved
jakubdyszkiewicz marked this conversation as resolved.
Show resolved Hide resolved

## Examples


Expand Down
Loading