Fix cpinstall tag for kong-mesh #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianrbz
requested review from
michaelbeaumont and
lobkovilya
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fabianrbz
force-pushed
the
fix-cpinstall-for-mesh
branch
from
5ac5975 to
a4c52b5
Compare
lahabana
reviewed
Nov 16, 2023
lahabana
approved these changes
Nov 16, 2023
|
@lahabana can we merge this? |
|
@fabianrbz you need to sign your commit: https://github.com/kumahq/.github/blob/main/CONTRIBUTING.md#sign-your-commits |
fabianrbz
force-pushed
the
fix-cpinstall-for-mesh
branch
from
a4c52b5 to
16a04bc
Compare
|
@lahabana done |
There's a slight difference between Kuma and Kong Mesh in terms of the base segment of the docs' url. For Kuma, all the docs live under `/docs/`. Unfortunately, that's not the case for Kong Mesh. Kong docs renders multiple products, so we namespace the docs with the corresponding product name, i.e. they live under `/mesh/`. This commit updates the tag's code so that it uses the base path in which the page is generated as the first url segment. That way we can re-use the code in both platforms. It also modifies the link that is rendered, so that it uses `page.release` instead of `page.version` so that it also works for both docs sites. Signed-off-by: Fabian Rodriguez <[email protected]>
fabianrbz
force-pushed
the
fix-cpinstall-for-mesh
branch
from
16a04bc to
9d09be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a slight difference between Kuma and Kong Mesh regarding the base segment of the docs' URL.
For Kuma, all the docs live under
/docs/. Unfortunately, that's not the case for Kong Mesh. Kong docs renders multiple products, so we namespace the docs with the corresponding product name, i.e. they live under/mesh/.This commit updates the tag's code so that it uses the base path in which the page is generated as the first URL segment. That way we can re-use the code on both platforms.
It also modifies the rendered link, so that it uses
page.releaseinstead ofpage.versionto work for both docs sites.Steps to Reproduce
Visit multi-zone deployments and choose
helm. Thefollow these stepslink is broken.Did you sign your commit? Instructions
Have you read Contributing guidelines?