Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change vale reporter #1529

Merged
merged 3 commits into from
Nov 15, 2023
Merged

change vale reporter #1529

merged 3 commits into from
Nov 15, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Nov 14, 2023 •
edited
Loading

IMHO comments are better because

  • You can resolve it
  • You can discuss about it
  • Diff with resolved comments is easier to review

@jakubdyszkiewicz
ci: change vale reporter to github pr review
13e4b14 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz
test
4e43eee 
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 6470e94
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/65538fb8f6d6fe00086b82ac
😎 Deploy Preview https://deploy-preview-1529--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jakubdyszkiewicz
Revert "test"
6470e94 
This reverts commit 4e43eee.

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review November 14, 2023 15:19
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner November 14, 2023 15:19
@jakubdyszkiewicz jakubdyszkiewicz requested review from johncowen and kleinfreund and removed request for a team November 14, 2023 15:19
@bartsmykla bartsmykla merged commit 60098da into master Nov 15, 2023
14 checks passed
@bartsmykla bartsmykla deleted the vale-reporter branch November 15, 2023 05:10
@kong-docs kong-docs mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bartsmykla bartsmykla bartsmykla approved these changes

@johncowen johncowen Awaiting requested review from johncowen johncowen is a code owner automatically assigned from kumahq/kuma-website-maintainers

@kleinfreund kleinfreund Awaiting requested review from kleinfreund kleinfreund is a code owner automatically assigned from kumahq/kuma-website-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @bartsmykla