Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): prepare docs for 2.5 #1511

Merged
merged 2 commits into from
Nov 7, 2023
Merged

chore(release): prepare docs for 2.5 #1511

merged 2 commits into from
Nov 7, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Nov 7, 2023 •
edited
Loading

so we can use docs during stabilisation

EDIT:

I forgot dev also works with

{% if_version gte:2.5.x %}

so might not be neccessary

Did you sign your commit? Instructions yes

Have you read Contributing guidelines? yes

@slonka slonka requested a review from a team as a code owner November 7, 2023 07:18
@slonka slonka requested review from michaelbeaumont and lukidzi and removed request for a team November 7, 2023 07:18
@netlify Netlify
Copy link

netlify bot commented Nov 7, 2023 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 532c210
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6549fccceb8dd3000832363f
😎 Deploy Preview https://deploy-preview-1511--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slonka slonka requested a review from lahabana November 7, 2023 07:20
lahabana
lahabana approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but how come the versions.yaml didn't get auto copied?

@lahabana lahabana merged commit 57a59aa into kumahq:master Nov 7, 2023
@kong-docs kong-docs mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont michaelbeaumont was automatically assigned from kumahq/kuma-website-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi was automatically assigned from kumahq/kuma-website-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @lahabana