Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mlbs): documentation of advanced locality awareness #1506

Merged
merged 23 commits into from
Nov 14, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Nov 3, 2023

Signed-off-by: Lukasz Dziedziak <[email protected]>
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 11473ad
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/65537d5dc06fc500087980f5
😎 Deploy Preview https://deploy-preview-1506--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lukidzi lukidzi changed the title feat(mlbs): create first draft feat(mlbs): documentation of advanced locality awareness Nov 3, 2023
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi marked this pull request as ready for review November 8, 2023 15:18
@lukidzi lukidzi requested a review from a team as a code owner November 8, 2023 15:18
@lukidzi lukidzi requested review from slonka and Automaat and removed request for a team November 8, 2023 15:18
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and nitpicks and one thing that I think is clearly wrong.

Also, the egress part will be in a separate PR right?

app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from slonka November 10, 2023 12:53
slonka
slonka previously requested changes Nov 13, 2023
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed. Also during test Friday we had this situation when we scaled down redis in one zone to 0 instances and then the traffic was completely not working even though we had failover defined. Switching address to .mesh helped. I think we should document this as well. Also should we document the pooling problem? When we only send 1 request concurrently then the connection for subsequent requests is always reused from the pool and it might not be load balanced across different backends (this is more of a demo scenario, not real prod environment, but might be helpful for people just trying this out).

app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
@lahabana
Copy link
Contributor

Can we update this page:
https://kuma.io/docs/dev/policies/locality-aware/ ?

Let's make sure we say folks should stop using this and use our new more expressive feature instead

@lahabana
Copy link
Contributor

These titles are confusing:

image

It's only advanced because we used to have something before. I think now there should be a single title "laLB" and then subsections:

  • default behaviour
  • disabling cross-zone routing
  • configuring laLB

Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
app/_src/policies/meshloadbalancingstrategy.md Outdated Show resolved Hide resolved
Automaat and others added 3 commits November 13, 2023 12:57
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Charly Molter <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi and others added 3 commits November 13, 2023 14:41
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM appart from some of these Vale warnings which seem genuine

Signed-off-by: Lukasz Dziedziak <[email protected]>
@lahabana lahabana enabled auto-merge (squash) November 14, 2023 14:20
@lahabana lahabana merged commit 781a2dd into kumahq:master Nov 14, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants