-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mlbs): documentation of advanced locality awareness #1506
Conversation
Signed-off-by: Lukasz Dziedziak <[email protected]>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments and nitpicks and one thing that I think is clearly wrong.
Also, the egress part will be in a separate PR right?
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed. Also during test Friday we had this situation when we scaled down redis in one zone to 0 instances and then the traffic was completely not working even though we had failover defined. Switching address to .mesh
helped. I think we should document this as well. Also should we document the pooling problem? When we only send 1 request concurrently then the connection for subsequent requests is always reused from the pool and it might not be load balanced across different backends (this is more of a demo scenario, not real prod environment, but might be helpful for people just trying this out).
Can we update this page: Let's make sure we say folks should stop using this and use our new more expressive feature instead |
Co-authored-by: Krzysztof Słonka <[email protected]> Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]> Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Charly Molter <[email protected]> Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Charly Molter <[email protected]> Signed-off-by: Marcin Skalski <[email protected]>
Co-authored-by: Charly Molter <[email protected]> Co-authored-by: Krzysztof Słonka <[email protected]> Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Charly Molter <[email protected]> Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM appart from some of these Vale warnings which seem genuine
Signed-off-by: Lukasz Dziedziak <[email protected]>
Rendered: https://deploy-preview-1506--kuma.netlify.app/docs/dev/policies/meshloadbalancingstrategy/#advanced-localityawareness
Did you sign your commit? Instructions
Have you read Contributing guidelines?
xref: #1475