fix: sidebar being too tall #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2023 10:34
Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 3 commits
November 3, 2023 15:21
Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
kleinfreund
requested review from
michaelbeaumont and
lukidzi
and removed request for
a team
michaelbeaumont
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
LGTM, seems to fix it
Getting to the bottom of the scrollbar on
https://kuma.io/docs/2.4.x/production/cp-deployment/stand-alone/
vs https://deploy-preview-1505--kuma.netlify.app/docs/2.4.x/production/cp-deployment/stand-alone/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the sidebar being too tall which messes up the scrolling behavior: one currently often needs to scroll all the way to the bottom of the page to see the bottom items of the sidebar. This PR changes the sidebar behavior so that the sidebar can always be scrolled individually regardless of the main content height.
Resolves #1321.
Notes
I made some development setup-related changes that I ran into while working on this.
One note on the development setup using
make run: I had trouble getting things working and ultimately, with the help of @fabianrbz, got a working development server working by removingnetlify: sleep 50 && netlify devfrom theProcfile. I haven’t committed this change here because I’m not entirely sure what it implies.