fix: make port 22 in transparent-proxy clear #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charly Molter <[email protected]>
lahabana
requested review from
michaelbeaumont and
Automaat
and removed request for
a team
❌ Deploy Preview for kuma failed.
|
slonka
reviewed
Oct 23, 2023
| @@ -51,11 +51,23 @@ The host that will run the `kuma-dp` process in transparent proxying mode needs | |||
| --redirect-dns | |||
| ``` | |||
|
|
|||
|
|
|||
| {% endwarning %} | ||
|
|
||
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy`. | ||
|
|
| {% endwarning %} | ||
|
|
||
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy`. | ||
|
|
||
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy` {% if_version gte:2.2.x %} (which is not implemented yet see issue [#8071](https://github.com/kumahq/kuma/issues/8071)).{% endif_version %} |
There was a problem hiding this comment.
It only makes sense when you know that we rewrote TP. Why would we mention a command that does not exist.
I'd go with:
Suggested change
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy` {% if_version gte:2.2.x %} (which is not implemented yet see issue [#8071](https://github.com/kumahq/kuma/issues/8071)).{% endif_version %} | |
| The changes will persist over restarts, so this command is needed only once. {% if_version lte:2.1.x %} Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy`.{% endif_version %}{% if_version gte:2.2.x %} Reverting to the original state of the host is not yet implemented, see issue [#8071](https://github.com/kumahq/kuma/issues/8071).{% endif_version %} |
There was a problem hiding this comment.
Wait. kumactl install transparent-proxy needs to be executed after every system reboot or you need to have some solution for iptables rules persistence in place. Otherwise, the transparent proxy configuration won't survive restarts.
bartsmykla
requested changes
Nov 8, 2023
| {% endwarning %} | ||
|
|
||
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy`. | ||
|
|
||
| The changes will persist over restarts, so this command is needed only once. Reverting to the original state of the host can be done by issuing `kumactl uninstall transparent-proxy` {% if_version gte:2.2.x %} (which is not implemented yet see issue [#8071](https://github.com/kumahq/kuma/issues/8071)).{% endif_version %} |
There was a problem hiding this comment.
Wait. kumactl install transparent-proxy needs to be executed after every system reboot or you need to have some solution for iptables rules persistence in place. Otherwise, the transparent proxy configuration won't survive restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Explain your change!>
Did you sign your commit? Instructions
Have you read Contributing guidelines?